Introduce PrimitiveValueDecoder to enable batch decoding of values #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the benchmarks are kinda simple, they identified (via flamegraph) that there was a significant amount of time being spent on next() calls in RleReaderV2. So introduce a new PrimitiveValueDecoder to enable batch decoding support, currently only properly implemented for integer arrays with no null buffer. Even so, benchmarks show significant improvement:
Next steps would be to use this in more places (over current Iterator::next() approach), with accompanying benchmarks to prove its a performance improvement.