Add iceberg feature
#256
Merged
Add iceberg feature
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmturner
commented
Dec 3, 2024
matthewmturner
commented
Dec 3, 2024
src/execution/local.rs
Outdated
Comment on lines
119
to
131
| pub async fn register_extensions(&mut self) -> Result<()> { | ||
| let ctx = &mut self.session_ctx; | ||
| let config = &self.config; | ||
| let extensions = enabled_extensions(); | ||
| // Apply any additional setup to the session context (e.g. registering | ||
| // functions) | ||
| for extension in &extensions { | ||
| extension.register_on_ctx(config, ctx)?; | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
New method for registering extensions
matthewmturner
commented
Dec 3, 2024
|
for this initial pr im just going to register the table provider factory, i will elicit feedback from the iceberg community about how to best integrate iceberg catalogs. |
|
I am merging this as is for now as there isnt a clear easy solution to adding testing for iceberg - i anticipate coming back to this though since i do plan on eventually turning dft as a library in an app i will be building that will likely use iceberg as a catalog. I am keeping my eye on lakekeeper as part of these efforts and may end up utilizing their rest catalog implementation for testing purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.