Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight for keywords #149

Conversation

matthewmturner
Copy link
Collaborator

@matthewmturner matthewmturner commented Sep 20, 2024

Adds basic keyboard driven syntax highlighting

image

@matthewmturner matthewmturner merged commit 3c3daa1 into datafusion-contrib:main Sep 20, 2024
3 checks passed
@matthewmturner
Copy link
Collaborator Author

@alamb FYI we have some basic syntax highlighting now

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There is talk upstream in sqlparser-rs of adding better support for this too

apache/datafusion-sqlparser-rs#1435

@matthewmturner
Copy link
Collaborator Author

@alamb fyi i put this in the config as an experimental option since it wasnt working great beyond the simple cases. I believe we'll just need to play with the regex for determining whats highlighted - but maybe something with sqlparser could help as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants