Add support for arc direction to v3 node #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyurva
approved these changes
Nov 14, 2024
| getEdgesByObjectID: ` | ||
| GRAPH DCGraph MATCH (n:Node)-[e:Edge | ||
| WHERE | ||
| e.object_id IN UNNEST(@ids) |
There was a problem hiding this comment.
Have we created an index by object_id? Any difference in performance between the 2 queries?
There was a problem hiding this comment.
Yep there's an object->predicate index. So far for these smaller queries it seems okay, but in-arcs tend to be much larger than out-arcs so this will probably need pagination eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds base query for in-arcs
Still TODO for Node: