Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue100 #130

Merged
merged 9 commits into from
Aug 12, 2024
Merged

Issue100 #130

merged 9 commits into from
Aug 12, 2024

Conversation

jeestr4d
Copy link
Collaborator

No description provided.

@jeestr4d jeestr4d self-assigned this May 24, 2024
@jeestr4d
Copy link
Collaborator Author

Fix for Issue #100
Local Pytest result

`tests/firmware32_64_bit_check/test_32_64_bit_firmware_check.py::test_logic[icurl_outputs0-5.2(7f)-6.0(2h)-FAIL - OUTAGE WARNING!!] PASSED [ 23%]
tests/firmware32_64_bit_check/test_32_64_bit_firmware_check.py::test_logic[icurl_outputs1-4.2(7f)-6.0(2h)-FAIL - OUTAGE WARNING!!] PASSED [ 23%]
tests/firmware32_64_bit_check/test_32_64_bit_firmware_check.py::test_logic[icurl_outputs2-5.2(7f)-6.0(2h)-PASS] PASSED [ 24%]
tests/firmware32_64_bit_check/test_32_64_bit_firmware_check.py::test_logic[icurl_outputs3-5.1(1a)-5.2(7d)-N/A] PASSED [ 24%]

`

@monrog2 monrog2 linked an issue Aug 12, 2024 that may be closed by this pull request
@monrog2
Copy link
Collaborator

monrog2 commented Aug 12, 2024

refactored logic and tests. added docs.

new pytest output:

[Check  1/1] 32 and 64-Bit Firmware Image for Switches...                                                        FAIL - UPGRADE FAILURE!!
  Target Switch Version  32-Bit Image Found  64-Bit Image Found
  ---------------------  ------------------  ------------------
  n9000-16.0(3e)         False               True

  Recommended Action: Upload the missing 32 or 64 bit Switch Image to the Firmware repository
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#602-requires-32-and-64-bit-switch-images


[Check  1/1] 32 and 64-Bit Firmware Image for Switches...                                                        FAIL - UPGRADE FAILURE!!
  Target Switch Version  32-Bit Image Found  64-Bit Image Found
  ---------------------  ------------------  ------------------
  n9000-16.0(3e)         False               False

  Recommended Action: Upload the missing 32 or 64 bit Switch Image to the Firmware repository
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#602-requires-32-and-64-bit-switch-images


[Check  1/1] 32 and 64-Bit Firmware Image for Switches...                                                                            PASS
[Check  1/1] 32 and 64-Bit Firmware Image for Switches... Target version below 6.0(2)                                                 N/A

Integration tests currently running

@monrog2 monrog2 self-requested a review August 12, 2024 19:42
Copy link
Collaborator

@monrog2 monrog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge master

monrog2
monrog2 previously approved these changes Aug 12, 2024
@monrog2 monrog2 merged commit 4391393 into master Aug 12, 2024
@monrog2 monrog2 deleted the Issue100 branch August 12, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

64-Bit and 32-Bit Pre Upgrade Repository Check
2 participants