Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#25 Added logic for CSCwb91766: check Subnet and static route overlap #121

Closed
wants to merge 1 commit into from
Closed

#25 Added logic for CSCwb91766: check Subnet and static route overlap #121

wants to merge 1 commit into from

Conversation

monrog2
Copy link
Collaborator

@monrog2 monrog2 commented May 14, 2024

@monrog2 monrog2 linked an issue May 14, 2024 that may be closed by this pull request
Upgrading to 5.2(4) from 4.x can cause /32 static routes to not be installed in FIB #25
Closed
monrog2
monrog2 commented May 14, 2024
View reviewed changes
Copy link
Collaborator Author

@monrog2 monrog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition:

  1. validations/md docs should be updated to include details about this check
  2. include the output of your local pytest run for reference
  3. indicate if the integration tests were all successful for your check

aci-preupgrade-validation-script.py Show resolved Hide resolved
aci-preupgrade-validation-script.py Show resolved Hide resolved
aci-preupgrade-validation-script.py Show resolved Hide resolved
aci-preupgrade-validation-script.py Show resolved Hide resolved
aci-preupgrade-validation-script.py Show resolved Hide resolved
aci-preupgrade-validation-script.py Show resolved Hide resolved
tests/static_route_overlap_check/test_static_route_overlap_check.py Show resolved Hide resolved
aci-preupgrade-validation-script.py Show resolved Hide resolved
tests/static_route_overlap_check/fvSubnet.json Show resolved Hide resolved
tests/static_route_overlap_check/fvRsCtx.json Show resolved Hide resolved
@monrog2 monrog2 changed the title Added logic for CSCwb91766: check Subnet and static route overlap #25 Added logic for CSCwb91766: check Subnet and static route overlap May 15, 2024
@jeestr4d
Copy link
Collaborator

Fix for all comments found in #129

@jeestr4d jeestr4d closed this May 22, 2024
@monrog2 monrog2 deleted the 25-CSCwb91766-subnet-static-route-overlap branch August 12, 2024 16:03
@monrog2 monrog2 removed a link to an issue Aug 12, 2024
Upgrading to 5.2(4) from 4.x can cause /32 static routes to not be installed in FIB #25
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeestr4d jeestr4d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monrog2 @jeestr4d