Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post upgrade Cb Check #110

Merged
merged 11 commits into from
May 8, 2024
Merged

Add post upgrade Cb Check #110

merged 11 commits into from
May 8, 2024

Conversation

monrog2
Copy link
Collaborator

@monrog2 monrog2 commented Apr 30, 2024

No description provided.

@monrog2 monrog2 linked an issue Apr 30, 2024 that may be closed by this pull request
Add recommendation to run Post-Upgrade-CB-Checker after apic upgrade completes #99
Closed
@monrog2 monrog2 changed the title Welkin post upgrade db Add post upgrade Cb Check Apr 30, 2024
@takishida takishida linked an issue May 7, 2024 that may be closed by this pull request
Add Post Upgrade Check Required result category #104
Closed
@takishida takishida force-pushed the welkin-post-upgrade-db branch from a2ad65e to a6ffd5c Compare May 7, 2024 00:53
@takishida takishida marked this pull request as ready for review May 7, 2024 00:55
@takishida
Copy link
Collaborator

Integration tests passed:

pytest outputs:

[Check  1/1] Post Upgrade Callback Integrity... Re-run script after APICs are upgraded and back to Fully-Fit  POST UPGRADE CHECK REQUIRED
[Check  1/1] Post Upgrade Callback Integrity... Re-run script after APICs are upgraded and back to Fully-Fit  POST UPGRADE CHECK REQUIRED
[Check  1/1] Post Upgrade Callback Integrity...                                                                                      PASS
[Check  1/1] Post Upgrade Callback Integrity...                                                                                      PASS
[Check  1/1] Post Upgrade Callback Integrity...                                                                   FAIL - OUTAGE WARNING!!
  Missed Objects       Impact
  --------------       ------
  infraImplicitSetPol  Infra implicit settings will not be deployed

  Recommended Action: Contact Cisco TAC with Output
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#post-upgrade-callback-integrity


[Check  1/1] Post Upgrade Callback Integrity...                                                                                      PASS
[Check  1/1] Post Upgrade Callback Integrity...                                                                   FAIL - OUTAGE WARNING!!
  Missed Objects       Impact
  --------------       ------
  fvSlaDef             IPSLA monitor policy will not be deployed
  infraImplicitSetPol  Infra implicit settings will not be deployed

  Recommended Action: Contact Cisco TAC with Output
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#post-upgrade-callback-integrity


[Check  1/1] Post Upgrade Callback Integrity...                                                                                      PASS
[Check  1/1] Post Upgrade Callback Integrity...                                                                   FAIL - OUTAGE WARNING!!
  Missed Objects                 Impact
  --------------                 ------
  fvSlaDef                       IPSLA monitor policy will not be deployed
  infraAssocEncapInstDef         VLAN for missing Mo will not be deployed to leaf
  infraImplicitSetPol            Infra implicit settings will not be deployed
  infraRsConnectivityProfileOpt  VPC for missing Mo will not be deployed to leaf

  Recommended Action: Contact Cisco TAC with Output
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#post-upgrade-callback-integrity


[Check  1/1] Post Upgrade Callback Integrity...                                                                                      PASS
[Check  1/1] Post Upgrade Callback Integrity...                                                                   FAIL - OUTAGE WARNING!!
  Missed Objects                 Impact
  --------------                 ------
  compatSwitchHw                 64/32 bit image can unexpectedly pushed to switches
  fvSlaDef                       IPSLA monitor policy will not be deployed
  infraAssocEncapInstDef         VLAN for missing Mo will not be deployed to leaf
  infraImplicitSetPol            Infra implicit settings will not be deployed
  infraRsConnectivityProfileOpt  VPC for missing Mo will not be deployed to leaf

  Recommended Action: Contact Cisco TAC with Output
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#post-upgrade-callback-integrity

monrog2
monrog2 commented May 8, 2024
View reviewed changes
Copy link
Collaborator Author

@monrog2 monrog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor impact change, otherwise ok. will self-push then merge

aci-preupgrade-validation-script.py Outdated Show resolved Hide resolved
monrog2
monrog2 commented May 8, 2024
View reviewed changes
Copy link
Collaborator Author

@monrog2 monrog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@monrog2 monrog2 merged commit 766ff1f into master May 8, 2024
@monrog2 monrog2 deleted the welkin-post-upgrade-db branch May 8, 2024 12:45
@monrog2 monrog2 linked an issue May 15, 2024 that may be closed by this pull request
New Validation Request: whether many interface override policies configured before upgrading to 5.2(4d) or above #74
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@welkin-he welkin-he

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@monrog2 @takishida @welkin-he