Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 bootflash fail over 50 if node already staged #108

Merged
merged 7 commits into from
May 6, 2024

Conversation

monrog2
Copy link
Collaborator

@monrog2 monrog2 commented Apr 29, 2024

can consider adding a new exception to catch the specific 121 response code for when API does not yet support the param being requested (older versions:)

[2024-04-29 18:21:44.342+0100 DEBUG                   icurl:613 ] response: {"totalCount":"1","imdata":[{"error":{"attributes":{"code":"121","text":"Prop 'dnldStatus' not found in class 'maintUpgJob' property table"}}}]}

[2024-04-29 18:21:44.343+0100 ERROR                <module>:3022] API call failed! Check debug log
Traceback (most recent call last):
  File "aci-preupgrade-validation-script.py", line 3010, in <module>
    r = check(idx + 1, len(checks), **inputs)
  File "aci-preupgrade-validation-script.py", line 1008, in switch_bootflash_usage_check
    download_sts = icurl('class', download_sts_api)
  File "aci-preupgrade-validation-script.py", line 616, in icurl
    raise Exception('API call failed! Check debug log')
Exception: API call failed! Check debug log

test result:

[Check 14/53] Switch Node /bootflash usage...                                                                     FAIL - UPGRADE FAILURE!!
  Pod-ID  Node-ID  Utilization         Alert
  ------  -------  -----------         -----
  1       109      63.85212250794009   Over 50% usage! Contact Cisco TAC for Support
  1       202      62.37069916322244   Over 50% usage! Contact Cisco TAC for Support
  2       113      62.566772442282684  Over 50% usage! Contact Cisco TAC for Support
  2       116      58.21308819390614   Over 50% usage! Contact Cisco TAC for Support

@monrog2 monrog2 linked an issue Apr 29, 2024 that may be closed by this pull request
@monrog2 monrog2 self-assigned this May 1, 2024
@monrog2
Copy link
Collaborator Author

monrog2 commented May 2, 2024

No related errors in integration test

local pytest output:

[Check  1/1] Switch Node /bootflash usage...                                                                     FAIL - UPGRADE FAILURE!!
  Pod-ID  Node-ID  Utilization         Alert
  ------  -------  -----------         -----
  1       101      51.279232107240844  Over 50% usage! Contact Cisco TAC for Support



[Check  1/1] Switch Node /bootflash usage... All below 50% or pre-downloaded                                                         PASS
[Check  1/1] Switch Node /bootflash usage...                                                                     FAIL - UPGRADE FAILURE!!
  Pod-ID  Node-ID  Utilization         Alert
  ------  -------  -----------         -----
  1       101      51.279232107240844  Over 50% usage! Contact Cisco TAC for Support

aci-preupgrade-validation-script.py Outdated Show resolved Hide resolved
aci-preupgrade-validation-script.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
monrog2 and others added 4 commits May 6, 2024 09:10
remove redundant check

Co-authored-by: takishida <[email protected]>
remove .keys() usage for py2

Co-authored-by: takishida <[email protected]>
whitespace

Co-authored-by: takishida <[email protected]>
remove .keys() use for py2 best practices

Co-authored-by: takishida <[email protected]>
@monrog2 monrog2 merged commit 1fd1a37 into master May 6, 2024
@monrog2 monrog2 deleted the 20-bootflash-fail-over-50-if-node-already-staged branch May 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootflash fail over 50% if node already staged
2 participants