Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

95 l3out route map with missing target #102

Merged
merged 2 commits into from
Apr 29, 2024
Merged

95 l3out route map with missing target #102

merged 2 commits into from
Apr 29, 2024

Conversation

takishida
Copy link
Collaborator

Fix #95

Sample outputs from pytest:

[Check  1/1] L3Out Route Map Match Rule with missing-target...                                                                        N/A
[Check  1/1] L3Out Route Map Match Rule with missing-target...                                                                        N/A
[Check  1/1] L3Out Route Map Match Rule with missing-target...                                                                       PASS
[Check  1/1] L3Out Route Map Match Rule with missing-target...                                                    FAIL - OUTAGE WARNING!!
  Tenant  L3Out  Route Map  Context  Action  Match Rule
  ------  -----  ---------  -------  ------  ----------
  TK      OSPF   RMAP1      CTX1     permit  Subj1

  Recommended Action: The configured match rules do not exist. Update the route maps with existing match rules.
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#l3out-route-map-match-rule-with-missing-target


[Check  1/1] L3Out Route Map Match Rule with missing-target...                                                    FAIL - OUTAGE WARNING!!
  Tenant  L3Out  Route Map  Context  Action  Match Rule
  ------  -----  ---------  -------  ------  ----------
  TK      OSPF   RMAP1      CTX1     permit  Subj1
  TK      OSPF   RMAP1      CTX2     permit  Subj2

  Recommended Action: The configured match rules do not exist. Update the route maps with existing match rules.
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#l3out-route-map-match-rule-with-missing-target


[Check  1/1] L3Out Route Map Match Rule with missing-target...                                                    FAIL - OUTAGE WARNING!!
  Tenant  L3Out  Route Map  Context  Action  Match Rule
  ------  -----  ---------  -------  ------  ----------
  TK      BGP    RMAP2      CTX0     deny    Subj0
  TK      OSPF   RMAP1      CTX1     permit  Subj1

  Recommended Action: The configured match rules do not exist. Update the route maps with existing match rules.
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#l3out-route-map-match-rule-with-missing-target

monrog2
monrog2 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@monrog2 monrog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text is fine, tests look good

@monrog2 monrog2 merged commit 4652f64 into master Apr 29, 2024
@monrog2 monrog2 deleted the 95-l3out-route-map-with-missing-target branch April 29, 2024 14:04
jeestr4d pushed a commit to jeestr4d/ACI-Pre-Upgrade-Validation-Script that referenced this pull request Apr 29, 2024
@takishida @jeestr4d
95 l3out route map with missing target (datacenter#102)
c5dff00 
* Add route-map missing-target check

* Update doc
@jeestr4d jeestr4d mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monrog2 monrog2 monrog2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewValidation: L3Out route-map with a missing-target match rule
2 participants
@takishida @monrog2