Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggplot2 package #142

Closed
LizZhou opened this issue Jul 21, 2023 · 1 comment · Fixed by #147
Closed

ggplot2 package #142

LizZhou opened this issue Jul 21, 2023 · 1 comment · Fixed by #147

Comments

@LizZhou
Copy link

LizZhou commented Jul 21, 2023

In the introduction part of ggplot2 (https://github.com/datacarpentry/r-intro-geospatial/blob/main/episodes/07-plot-ggplot2.Rmd), it was saying the ggplot2 was the most effective for creating publication quality graphics. I agree with that, however, I'm wondering if it's better to say it's one of the best because determining the best also depends on the needs of the users I think.
@mikemahoney218
Copy link
Member

Even though I do think ggplot2 is the best (😆), I agree with this change! We might also consider "one of the leading" or "one of the most popular" (but I'm comfortable with your version as well).

@LizZhou , do you want to contribute a PR to do this?

@albhasan albhasan mentioned this issue Nov 3, 2023
Merged
kristi-sara added a commit that referenced this issue Oct 18, 2024
@kristi-sara
Merge pull request #147 from albhasan/ggplot2_142
3a09f64 
Closes #142 I'm going to go ahead and merge this, its just fixing the language in the ggplot2 lesson
github-actions bot pushed a commit that referenced this issue Oct 18, 2024
@actions-user
markdown source builds
3b11314 
Auto-generated via `{sandpaper}`
Source  : 3a09f64
Branch  : main
Author  : Kristi Liu <[email protected]>
Time    : 2024-10-18 00:02:08 +0000
Message : Merge pull request #147 from albhasan/ggplot2_142

Closes #142 I'm going to go ahead and merge this, its just fixing the language in the ggplot2 lesson
github-actions bot pushed a commit that referenced this issue Oct 18, 2024
@actions-user
site deploy
d4bd84c 
Auto-generated via `{sandpaper}`
Source  : 3b11314
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-18 00:03:13 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3a09f64
Branch  : main
Author  : Kristi Liu <[email protected]>
Time    : 2024-10-18 00:02:08 +0000
Message : Merge pull request #147 from albhasan/ggplot2_142

Closes #142 I'm going to go ahead and merge this, its just fixing the language in the ggplot2 lesson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #142 albhasan/r-intro-geospatial
2 participants
@mikemahoney218 @LizZhou