Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added crawler for Azure Service principals used for direct storage access #305

Merged
merged 11 commits into from
Sep 28, 2023
Merged

Added crawler for Azure Service principals used for direct storage access #305

merged 11 commits into from
Sep 28, 2023

Conversation

dipankarkush-db
Copy link
Contributor

Fixes #249

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #305 (543e2a0) into main (4fe6ed8) will increase coverage by 0.27%.
Report is 3 commits behind head on main.
The diff coverage is 84.48%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   83.27%   83.54%   +0.27%     
==========================================
  Files          30       30              
  Lines        2146     2242      +96     
  Branches      366      389      +23     
==========================================
+ Hits         1787     1873      +86     
- Misses        279      285       +6     
- Partials       80       84       +4
Files Coverage Δ
src/databricks/labs/ucx/assessment/crawlers.py 73.29% <84.48%> (+6.34%) ⬆️

... and 2 files with indirect coverage changes

nfx
nfx requested changes Sep 27, 2023
View reviewed changes
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
tests/integration/hive_metastore/test_tables.py Outdated Show resolved Hide resolved
tests/unit/assessment/test_assessment.py Outdated Show resolved Hide resolved
tests/unit/assessment/test_assessment.py Outdated Show resolved Hide resolved
@dipankarkush-db dipankarkush-db marked this pull request as ready for review September 27, 2023 23:44
nfx
nfx requested changes Sep 28, 2023
View reviewed changes
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
nfx
nfx requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spn conf checking logic is reported effectively 6 times, refactor it into a function.

src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Show resolved Hide resolved
nfx
nfx requested changes Sep 28, 2023
View reviewed changes
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/assessment/crawlers.py Outdated Show resolved Hide resolved
nfx
nfx approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nfx nfx added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 82bdd33 Sep 28, 2023
nfx added a commit that referenced this pull request Sep 29, 2023
@nfx
Release v0.2.0
f885a0d 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to workspace-level groups in case no explicit configuration ([#277](#277)).
* Added crawler for Azure Service principals used for direct storage access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard ([#269](#269)).
* Added filtering out for job clusters in the clusters crawler ([#298](#298)).
* Added recording errors from `crawl_tables` step in `$inventory.table_failures` table and display counter on the dashboard ([#300](#300)).
* Added comprehensive introduction user manual ([#273](#273)).
* Added interactive tutorial for local group migration readme ([#291](#291)).
* Added tutorial links to the landing page of documentation ([#290](#290)).
* Added (internal) support for account-level configuration and multi-cloud workspace list ([#264](#264)).
* Improved order of tasks in the README notebook ([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal ([#282](#282)).
* Improved installation script by setting log level to uppercase by default ([#271](#271)).
* Improved installation finish messages within installer script ([#267](#267)).
* Improved automation for `MANAGED` table migration and continued building tables migration component ([#295](#295)).
* Fixed debug notebook code with refactored package structure ([#250](#250)) ([#265](#265)).
* Fixed replacement of custom configured database to replicate in the report for external locations ([#296](#296)).
* Removed redundant `notebooks` top-level folder ([#263](#263)).
* Split checking for test failures and linting errors into independent GitHub Actions checks ([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests ([#294](#294)).
@nfx nfx mentioned this pull request Sep 29, 2023
Merged
nfx added a commit that referenced this pull request Sep 29, 2023
@nfx
Release v0.2.0 (#328)
b81abea 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
FastLee pushed a commit that referenced this pull request Sep 29, 2023
@dipankarkush-db @FastLee
Added crawler for Azure Service principals used for direct storage ac…
405e9b0 
…cess (#305)

Fixes #249
FastLee pushed a commit that referenced this pull request Sep 29, 2023
@nfx @FastLee
Release v0.2.0 (#328)
b6015a6 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
@nfx nfx deleted the fix/azure-SPNs branch October 2, 2023 17:20
@nfx nfx restored the fix/azure-SPNs branch October 2, 2023 17:20
@nfx nfx deleted the fix/azure-SPNs branch October 2, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

@larsgeorge-db larsgeorge-db Awaiting requested review from larsgeorge-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create inventory of service principals and direct files access in Azure
2 participants
@dipankarkush-db @nfx