Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more value inference for dbutils.notebook.run(...) #1860

Merged
merged 19 commits into from
Jun 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
register loadable dependencies
ericvergnaud committed Jun 7, 2024
commit 91bce51387a5e2a95746608bed2950d6c5df5fb6
20 changes: 11 additions & 9 deletions src/databricks/labs/ucx/source_code/graph.py
Original file line number Diff line number Diff line change
@@ -186,15 +186,17 @@ def _process_node(self, base_node: NodeBase):
self._mutate_path_lookup(base_node)
if isinstance(base_node, NotebookRunCall):
paths = base_node.get_notebook_paths()
if None in paths:
yield DependencyProblem(
'dependency-too-complex',
f"Can't check dependency from {base_node.node.as_string()} because the expression is too complex",
)
else:
for path in paths:
assert isinstance(path, str)
yield from self.register_notebook(Path(path))
asserted = False
for path in paths:
if path is None:
if not asserted:
asserted = True
yield DependencyProblem(
'dependency-cannot-compute',
f"Can't check dependency from {base_node.node.as_string()} because the expression cannot be computed",
)
continue
yield from self.register_notebook(Path(path))
if isinstance(base_node, ImportSource):
prefix = ""
if isinstance(base_node.node, ImportFrom) and base_node.node.level is not None: