Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace_start_path is ignored during workspace listing #427

Closed
william-conti opened this issue Oct 10, 2023 · 2 comments
Closed

workspace_start_path is ignored during workspace listing #427

william-conti opened this issue Oct 10, 2023 · 2 comments
Labels
step/assessment go/uc/upgrade - Assessment Step

Comments

@william-conti
Copy link
Contributor

When a user set workspace_start_path in config.yml it is completly ignored by WorkspaceListing and it scans all the user paths.

image
@github-project-automation github-project-automation bot moved this to Triage in UCX Oct 10, 2023
@william-conti william-conti added bug step/assessment go/uc/upgrade - Assessment Step labels Oct 10, 2023
pritishpai added a commit that referenced this issue Oct 12, 2023
@pritishpai
crawl_permissions task in assessment to respect 'workspace_start_path…
7ce154d 
…' config (#427)

The crawl_permissions task in assessment would not respect the config value of workspace_start_path as it was not present in the 'from_dict' classmethod. Added an extraction for the config.

Removed dbconnect from Contributing README as it is no longer needed.
@pritishpai pritishpai self-assigned this Oct 12, 2023
@larsgeorge-db
Copy link
Contributor

@pritishpai could you open a PR for just this fix (and not dropping a dependency) please?

@nfx
Copy link
Collaborator

nfx commented Oct 17, 2023

fixed in 1d6377e

@nfx nfx closed this as completed Oct 17, 2023
@github-project-automation github-project-automation bot moved this from Triage to Archive in UCX Oct 17, 2023
@pritishpai pritishpai removed their assignment Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
step/assessment go/uc/upgrade - Assessment Step
Projects
UCX
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nfx @william-conti @larsgeorge-db @pritishpai