Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Circular dependency for migrate-locations #2529

Closed
1 task done
FastLee opened this issue Sep 4, 2024 · 0 comments · Fixed by #2741
Closed
1 task done

[BUG]: Circular dependency for migrate-locations #2529

FastLee opened this issue Sep 4, 2024 · 0 comments · Fixed by #2741
Assignees
@HariGS-DB
Labels
cloud/aws Issues related to AWS cloud/azure issues related to Azure

Comments

@FastLee
Copy link
Contributor

FastLee commented Sep 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Using the migrate-locations cli command triggers the
AWSExternalLocationsMigration.run method
The method calls
apply_location_acl() method from PrincipalACL
The apply_location_acl() method is dependent on the existing UC External Locations which creates a circular dependency.
We need to redesign the flow to break this loop.

Expected Behavior

migrate-locations should be able to create external locations and apply principal acls in both AWS/Azuree

Steps To Reproduce

Run migrate locations in AWS where principal ACLs exist.

Cloud

AWS

Operating System

macOS

Version

latest via Databricks CLI

Relevant log output

No response
@FastLee FastLee added bug cloud/azure issues related to Azure cloud/aws Issues related to AWS labels Sep 4, 2024
@HariGS-DB HariGS-DB mentioned this issue Sep 25, 2024
Merged
3 tasks
@nfx nfx closed this as completed in #2741 Sep 25, 2024
@nfx nfx closed this as completed in 564e504 Sep 25, 2024
jgarciaf106 pushed a commit to rportilla-databricks/ucx that referenced this issue Sep 26, 2024
@HariGS-DB @aminmovahed-db @jgarciaf106
Fixes issue of circular dependency of migrate-location ACL (databrick…
2a09a8f 
…slabs#2741)

<!-- REMOVE IRRELEVANT COMMENTS BEFORE CREATING A PULL REQUEST -->
## Changes
<!-- Summary of your changes that are easy to understand. Add
screenshots when necessary -->


Resolves databrickslabs#2529 

### Functionality

- [ ] modified existing command: `databricks labs ucx migrate-locations`

### Tests
<!-- How is this tested? Please see the checklist below and also
describe any other relevant tests -->

- [ ] added unit tests
- [ ] added integration tests

---------

Co-authored-by: Amin Movahed <[email protected]>
Co-authored-by: Amin Movahed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HariGS-DB HariGS-DB

Labels
cloud/aws Issues related to AWS cloud/azure issues related to Azure
Projects
UCX (weekly) - DO NOT USE THIS BOARD
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue of circular dependency of migrate-location ACL databrickslabs/ucx
2 participants
@FastLee @HariGS-DB