Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: linting for spark.table reports unrelated issues #2017

Closed
1 task done
ericvergnaud opened this issue Jul 2, 2024 · 0 comments · Fixed by #2114
Closed
1 task done

[BUG]: linting for spark.table reports unrelated issues #2017

ericvergnaud opened this issue Jul 2, 2024 · 0 comments · Fixed by #2114
Assignees
@ericvergnaud

Comments

@ericvergnaud
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When linting spacy.pipe_analysis, the linter reports the following advice:
Can't migrate 'msg.table(body, header=header, divider=True, multiline=True)' because its table name argument cannot be computed

Expected Behavior

There should be no advice for msg.table(...)

Steps To Reproduce

No response

Cloud

AWS

Operating System

macOS

Version

latest via Databricks CLI

Relevant log output

No response
@ericvergnaud ericvergnaud mentioned this issue Jul 2, 2024
Merged
1 task
@nfx nfx removed the needs-triage label Jul 5, 2024
@ericvergnaud ericvergnaud self-assigned this Jul 8, 2024
@ericvergnaud ericvergnaud mentioned this issue Jul 9, 2024
Merged
1 task
nfx added a commit that referenced this issue Jul 9, 2024
@ericvergnaud @nfx
Fix false advice when linting homonymous method names (#2114)
bd99d7c 
## Changes
Checks that method names in scope for spar linting belong to spark
module
Update functional tests accordingly

### Linked issues
<!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes,
fixed, resolve, resolves, resolved. See
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

Resolves #2017 
Resolves #1213 
Progresses #1864
Progresses #1901 

### Functionality
None

### Tests
- [x] added unit tests

---------

Co-authored-by: Eric Vergnaud <[email protected]>
Co-authored-by: Serge Smertin <[email protected]>
@nfx nfx closed this as completed in #2114 Jul 9, 2024
@nfx nfx moved this from Todo to Done in UCX (weekly) - DO NOT USE THIS BOARD Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericvergnaud ericvergnaud

Labels
None yet
Projects
UCX (weekly) - DO NOT USE THIS BOARD
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix false advice when linting homonymous method names databrickslabs/ucx
2 participants
@nfx @ericvergnaud