Skip to content

Commit

Permalink
Fix Integration test failure of migration_tables (#3108)
Browse files Browse the repository at this point in the history
<!-- REMOVE IRRELEVANT COMMENTS BEFORE CREATING A PULL REQUEST -->
## Changes
<!-- Summary of your changes that are easy to understand. Add
screenshots when necessary -->
This change unskips the two integration test which are failing.
The underlying issue is fixed as part of
#3020


Resolves #3054 
Resolves #3055 

### Functionality


### Tests
<!-- How is this tested? Please see the checklist below and also
describe any other relevant tests -->

- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)
  • Loading branch information
HariGS-DB authored Nov 1, 2024
1 parent c4df7b1 commit 2456c51
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions tests/integration/hive_metastore/test_migrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ def test_migrate_external_table(
assert migration_status[0].dst_table == src_external_table.name


@pytest.mark.skip("https://github.com/databrickslabs/ucx/issues/3054")
def test_migrate_managed_table_to_external_table_without_conversion(
ws,
sql_backend,
Expand Down Expand Up @@ -219,7 +218,6 @@ def test_migrate_managed_table_to_external_table_without_conversion(
assert migration_status[0].dst_table == src_external_table.name


@pytest.mark.skip("https://github.com/databrickslabs/ucx/issues/3055")
def test_migrate_managed_table_to_external_table_with_clone(
ws,
sql_backend,
Expand Down
1 change: 0 additions & 1 deletion tests/unit/source_code/test_directfs_access.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
DirectFsAccess,
DirectFsAccessOwnership,
)
from databricks.labs.ucx.source_code.python.python_ast import DfsaPyCollector


def test_crawler_appends_dfsas() -> None:
Expand Down

0 comments on commit 2456c51

Please sign in to comment.