Greatly improve grammar for CREATE/ALTER #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimidle
added
internal
Coverage tests results401 tests ±0 200 ✅ ±0 4s ⏱️ ±0s For more details on these failures, see this check. Results for commit 76e613d. ± Comparison against base commit e0cd57e. ♻️ This comment has been updated with latest results. |
nfx
approved these changes
Aug 16, 2024
… improved TSQL grammar
jimidle
force-pushed
the
feature/carevamp
branch
from
5a7fa3d to
76e613d
Compare
sundarshankar89
pushed a commit
to sundarshankar89/remorph
that referenced
this pull request
Jan 2, 2025
Here, we greatly improve the grammar constructs for create and alter and additionally, make parsing of `id . id` orthogonal instead of having 17 rules to parse the same construct. We also remove the mountain of superfluous labels given to many tokens and rules, which just add bloat to the generated code. As a result, the error recovery mechanism is more accurate in identifying the source of syntax errors as there is much less ambiguity. The size of the generated parser file is also 'smaller' at 99387 lines vs 107354 - we intend to continue reducing this.
sundarshankar89
pushed a commit
to sundarshankar89/remorph
that referenced
this pull request
Jan 3, 2025
Here, we greatly improve the grammar constructs for create and alter and additionally, make parsing of `id . id` orthogonal instead of having 17 rules to parse the same construct. We also remove the mountain of superfluous labels given to many tokens and rules, which just add bloat to the generated code. As a result, the error recovery mechanism is more accurate in identifying the source of syntax errors as there is much less ambiguity. The size of the generated parser file is also 'smaller' at 99387 lines vs 107354 - we intend to continue reducing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, we greatly improve the grammar constructs for create and alter and additionally, make parsing of
id . idorthogonal instead of having 17 rules to parse the same construct.We also remove the mountain of superfluous labels given to many tokens and rules, which just add bloat to the generated code.
As a result, the error recovery mechanism is more accurate in identifying the source of syntax errors as there is much less ambiguity. The size of the generated parser file is also 'smaller' at 99387 lines vs 107354 - we intend to continue reducing this.