Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: Remove redundant grammar rules for a clean lint #804

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

jimidle
Copy link
Contributor

@jimidle jimidle commented Aug 15, 2024

The new ANTLR linter points out a number of unused rules in the Snowflake grammar. Here we resolve the linting errors, generally by deleting unused rules.

@jimidle jimidle added internal technical pr's not end user facing sql/snowflake labels Aug 15, 2024
Copy link

Coverage tests results

401 tests  ±0   200 ✅ ±0   4s ⏱️ ±0s
  2 suites ±0     0 💤 ±0 
  2 files   ±0   201 ❌ ±0 

For more details on these failures, see this check.

Results for commit e2dba02. ± Comparison against base commit dc8c596.

@jimidle jimidle requested a review from nfx August 15, 2024 15:10
@jimidle jimidle marked this pull request as ready for review August 15, 2024 15:11
@jimidle jimidle requested a review from a team as a code owner August 15, 2024 15:11
@jimidle jimidle requested a review from vijaypavann-db August 15, 2024 15:11
@jimidle jimidle added the antlr Changes to any of the ANTLR g4 grammar files. label Aug 15, 2024
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit e0cd57e into main Aug 16, 2024
9 checks passed
@nfx nfx deleted the feature/fixsnowgrammar branch August 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antlr Changes to any of the ANTLR g4 grammar files. internal technical pr's not end user facing sql/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants