Lose superflous alt in selectListElem #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 98.00% 98.00% -0.01%
==========================================
Files 62 62
Lines 3969 3968 -1
Branches 483 486 +3
==========================================
- Hits 3890 3889 -1
Misses 45 45
Partials 34 34 ☔ View full report in Codecov by Sentry. |
Coverage tests results375 tests ±0 265 ✅ ±0 6s ⏱️ ±0s For more details on these failures, see this check. Results for commit 8430d6e. ± Comparison against base commit 5cee796. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes superfluous alts defined in select list element rule in TSQL grammar. Also removes the accepts on it which were rightly not used.
Note that the rule for parsing udt column declarations may still be relevant for
CREATE TYPE, hence it is not removed.