Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar clean up and keyword expansion #437

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

jimidle
Copy link
Contributor

@jimidle jimidle commented Jun 6, 2024

An internal cleanup of grammar and keywords

  • Removes superfluous comments
  • Corrects hacks with "" strings
  • Expands keywords - for instance SELECT * FROM TABLE now works
  • Removes unused accumulated rules from TSQL

  - Removes superfluous comments
  - Corrects hacks with "" strings
  - Expands keywords - for instance SELECT * FROM TABLE now works
  - Removes unused accumulated rules from TSQL
@jimidle jimidle added the internal technical pr's not end user facing label Jun 6, 2024
@jimidle jimidle requested a review from a team as a code owner June 6, 2024 17:20
@jimidle jimidle requested review from ravit-db, vil1 and sundarshankar89 and removed request for ravit-db June 6, 2024 17:20
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (affdd32) to head (e3b989d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   97.94%   97.97%   +0.02%     
==========================================
  Files          61       61              
  Lines        3849     3894      +45     
  Branches      480      483       +3     
==========================================
+ Hits         3770     3815      +45     
  Misses         45       45              
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimidle jimidle enabled auto-merge June 6, 2024 17:23
Copy link

github-actions bot commented Jun 6, 2024

Coverage tests results

354 tests  ±0   251 ✅ +5   6s ⏱️ -1s
  2 suites ±0     0 💤 ±0 
  2 files   ±0   103 ❌  - 5 

For more details on these failures, see this check.

Results for commit e3b989d. ± Comparison against base commit 32c0d6e.

Copy link
Contributor

@vil1 vil1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jimidle jimidle added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 60850b1 Jun 7, 2024
10 checks passed
@jimidle jimidle deleted the feature/grammartidy branch June 7, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal technical pr's not end user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants