-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake add missing function definitions #433
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 97.97% 97.94% -0.04%
==========================================
Files 61 61
Lines 3894 4031 +137
Branches 483 483
==========================================
+ Hits 3815 3948 +133
- Misses 45 49 +4
Partials 34 34 ☔ View full report in Codecov by Sentry. |
Coverage tests results354 tests ±0 292 ✅ +41 4s ⏱️ -2s For more details on these failures, see this check. Results for commit 2b3fc75. ± Comparison against base commit 60850b1. ♻️ This comment has been updated with latest results. |
I would like to merge #430 before we merge this so we don't start repeating the same edits. That PR finishes all functions except for the more exotic stuff like freeText. You can then use the TSQL grammar changes as a template without worrying I will change them half way through your own re-work on Snowflake. |
What edits do you refer to? the one in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Add entries in
SnowflakeFunctionBuilder
for functions that were used in the acceptance tests but not "defined" yet.Note that the grammar around
function_call
has been reworked, this work is still in progress. Future work will include:builtin_function
(functions that have special syntax)aggregate_function
andranking_windowed_function