Updated test cases for Update DML statement
#160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 95.89% 95.94% +0.05%
==========================================
Files 19 19
Lines 1218 1234 +16
Branches 197 199 +2
==========================================
+ Hits 1168 1184 +16
Misses 25 25
Partials 25 25 ☔ View full report in Codecov by Sentry. |
bishwajit-db
reviewed
Mar 5, 2024
Comment on lines
+612
to
+618
| if from_sql: | ||
| from_sql = from_sql.replace("FROM", "USING", 1) | ||
| where_sql = where_sql.replace("WHERE", "ON") | ||
|
|
||
| expression_sql = f"{from_sql}{where_sql}{returning}" | ||
|
|
||
| if from_sql: |
There was a problem hiding this comment.
Minor ask: Can we combine the two if from_sql checks in 1 single block?
|
@vijaypavann-db close if this is duplicate |
|
Merged as part of the PR #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.