Display lsp diagnostics in console #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
changed the base branch from
main
to
feature/multiplexer/refactor-transpile-error-saved
ericvergnaud
changed the base branch from
feature/multiplexer/refactor-transpile-error-saved
to
feature/multiplexer/refactor-transpile-error
ericvergnaud
added
stacked PR
…-lsp * bump-max-args: bump max args
…ultiplexer/refactor-transpile-error * feature/multiplexer/transpile-using-lsp: fix typo add docs bump max args
…ure/multiplexer/display-lsp-diagnostics-in-console * feature/multiplexer/refactor-transpile-error: fix typo add docs bump max args
Base automatically changed from
feature/multiplexer/refactor-transpile-error
to
main
January 22, 2025 05:02
…in-console * main: Refactor transpile error for LSP (#1405) Rename mock (#1423) Update databricks-sdk requirement from ~=0.29.0 to >=0.29,<0.42 (#1422) Transpile using LSP (#1404) Bump sqlglot from 26.0.1 to 26.1.3 (#1416) Configure transpile errors file (#1408) restore lost file and fix gitignore that led to that loss (#1414) bump max args (#1410) # Conflicts: # src/databricks/labs/remorph/transpiler/execute.py # src/databricks/labs/remorph/transpiler/lsp/lsp_engine.py # src/databricks/labs/remorph/transpiler/sqlglot/sqlglot_engine.py # src/databricks/labs/remorph/transpiler/transpile_engine.py # tests/resources/lsp_transpiler/lsp_server.py # tests/unit/transpiler/test_lsp_engine.py
sundarshankar89
approved these changes
Jan 22, 2025
|
|
||
| status = do_transpile(ctx.workspace_client, engine, config) | ||
| for error in errors: | ||
| print(str(error)) |
There was a problem hiding this comment.
Suggested change
| print(str(error)) | |
| can we use logger instead when run in cli only stderr is redirected to console. |
ericvergnaud
deleted the
feature/multiplexer/display-lsp-diagnostics-in-console
branch
ericvergnaud
added a commit
that referenced
this pull request
Jan 22, 2025
* main: Display lsp diagnostics in console (#1406) Refactor transpile error for LSP (#1405) Rename mock (#1423) Update databricks-sdk requirement from ~=0.29.0 to >=0.29,<0.42 (#1422) Transpile using LSP (#1404) Bump sqlglot from 26.0.1 to 26.1.3 (#1416) Configure transpile errors file (#1408) restore lost file and fix gitignore that led to that loss (#1414) bump max args (#1410) # Conflicts: # README.md # labs.yml # src/databricks/labs/remorph/cli.py # src/databricks/labs/remorph/config.py # src/databricks/labs/remorph/install.py # src/databricks/labs/remorph/transpiler/execute.py # src/databricks/labs/remorph/transpiler/lsp/lsp_engine.py # tests/unit/test_cli_transpile.py # tests/unit/test_install.py # tests/unit/transpiler/test_execute.py # tests/unit/transpiler/test_lsp_engine.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation ignores LSP diagnostics.
Also it stores transpile errors in the target directory, but does not display them in the console.
This PR:
TranspileErrorsFixes #1301
Supersedes #1385