Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.14.0 specifies incorrect minimum required version of databricks-sdk #330

Closed
asnare opened this issue Nov 18, 2024 · 0 comments · Fixed by #331
Closed

Release 0.14.0 specifies incorrect minimum required version of databricks-sdk #330

asnare opened this issue Nov 18, 2024 · 0 comments · Fixed by #331
Assignees
Labels
bug Something isn't working

Comments

@asnare
Copy link
Contributor

asnare commented Nov 18, 2024

The changes in #320 mean that we no longer work with versions of databricks-sdk before 0.37.0. Unfortunately the current project specification allows any version after 0.29.0. This leads to downstream problems where the 0.14.0 release will be installed even if an earlier version of the SDK is in use.

This currently affects UCX and remorph.

@asnare asnare added the bug Something isn't working label Nov 18, 2024
@asnare asnare self-assigned this Nov 18, 2024
github-merge-queue bot pushed a commit to databrickslabs/remorph that referenced this issue Nov 19, 2024
The 0.14.0 release depends on Databricks SDK 0.37.0, but doesn't declare
this. As such it can't be installed due to our dependency on Databricks
SDK 0.29.0.

Reference: databrickslabs/lsql#330
JCZuurmond added a commit that referenced this issue Nov 19, 2024
* Changes to work with Databricks SDK `v0.38.0` ([#350](#350)). In this release, the open-source library has been updated to be compatible with Databricks SDK version 0.38.0, addressing issues [#349](#349) to [#332](#332). The changes include modifying the `create_dashboard` function, which now directly passes the `SDKDashboard` instance to the `ws.lakeview.create` and `ws.lakeview.update` methods, eliminating the need for dictionary conversions. A new SQL query, `NYC_TAXI_TRIPS_LIMITED`, has been introduced, and the `test_sql_execution` method has been updated to use this query. The `test_sql_execution_partial` and `test_sql_execution_as_iterator` methods have been removed, and the `test_fetch_one_works` method now includes an assertion to verify the returned row's `pickup_zip` value. These updates improve the library's compatibility with the latest Databricks SDK, refactor SQL query-based tests, and enhance test reliability.
* Specify the minimum required version of `databricks-sdk` as 0.37.0 ([#331](#331)). In this release, we have updated the minimum required version of the `databricks-sdk` package to 0.37.0, as specified in the project's `pyproject.toml` file. This update is necessary due to the modifications made in pull request [#320](#320), which constrains the `databricks-sdk` version to 0.37.x for compatible updates within the same minor version. This change also resolves issue [#330](#330). It is important to note that no new methods have been added or existing functionality changed in the codebase as part of this commit. Therefore, the impact on the existing functionality should be minimal and confined to the interaction with the `databricks-sdk` package.
JCZuurmond added a commit that referenced this issue Nov 19, 2024
* Changes to work with Databricks SDK `v0.38.0` ([#350](#350)). In this release, we have upgraded the Databricks SDK to version 0.38.0 from version 0.37.0 to ensure compatibility with the latest SDK and address several issues. The update includes changes to make the code compatible with the new SDK version, removing the need for `.as_dict()` method calls when creating or updating dashboards and utilizing a `sdk_dashboard` variable for interacting with the Databricks workspace. We also updated the dependencies to "databricks-labs-blueprint[yaml]" package version greater than or equal to 0.4.2 and `sqlglot` package version greater than or equal to 22.3.1. The `test_core.py` file has been updated to address multiple issues ([#349](#349) to [#332](#332)) related to the Databricks SDK and the `test_dashboards.py` file has been revised to work with the new SDK version. These changes improve integration with Databricks' lakeview dashboards, simplify the code, and ensure compatibility with the latest SDK version, resolving issues [#349](#349) to [#332](#332).
* Specify the minimum required version of `databricks-sdk` as 0.37.0 ([#331](#331)). In this release, we have updated the minimum required version of the `databricks-sdk` package to 0.37.0 from 0.29.0 in the `pyproject.toml` file to ensure compatibility with the latest version. This change was made necessary due to updates made in issue [#320](#320). To accommodate any patch release of `databricks-sdk` with a major and minor version of 0.37, we have updated the dependency constraint to use the `~=` operator, resolving issue [#330](#330). These changes are intended to enhance the compatibility and stability of our software.
JCZuurmond added a commit that referenced this issue Nov 19, 2024
* Changes to work with Databricks SDK `v0.38.0`
([#350](#350)). In this
release, we have upgraded the Databricks SDK to version 0.38.0 from
version 0.37.0 to ensure compatibility with the latest SDK and address
several issues. The update includes changes to make the code compatible
with the new SDK version, removing the need for `.as_dict()` method
calls when creating or updating dashboards and utilizing a
`sdk_dashboard` variable for interacting with the Databricks workspace.
We also updated the dependencies to "databricks-labs-blueprint[yaml]"
package version greater than or equal to 0.4.2 and `sqlglot` package
version greater than or equal to 22.3.1. The `test_core.py` file has
been updated to address multiple issues
([#349](#349) to
[#332](#332)) related to
the Databricks SDK and the `test_dashboards.py` file has been revised to
work with the new SDK version. These changes improve integration with
Databricks' lakeview dashboards, simplify the code, and ensure
compatibility with the latest SDK version, resolving issues
[#349](#349) to
[#332](#332).
* Specify the minimum required version of `databricks-sdk` as 0.37.0
([#331](#331)). In this
release, we have updated the minimum required version of the
`databricks-sdk` package to 0.37.0 from 0.29.0 in the `pyproject.toml`
file to ensure compatibility with the latest version. This change was
made necessary due to updates made in issue
[#320](#320). To
accommodate any patch release of `databricks-sdk` with a major and minor
version of 0.37, we have updated the dependency constraint to use the
`~=` operator, resolving issue
[#330](#330). These changes
are intended to enhance the compatibility and stability of our software.
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this issue Jan 2, 2025
The 0.14.0 release depends on Databricks SDK 0.37.0, but doesn't declare
this. As such it can't be installed due to our dependency on Databricks
SDK 0.29.0.

Reference: databrickslabs/lsql#330
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this issue Jan 3, 2025
The 0.14.0 release depends on Databricks SDK 0.37.0, but doesn't declare
this. As such it can't be installed due to our dependency on Databricks
SDK 0.29.0.

Reference: databrickslabs/lsql#330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant