Remove Dashboard.as_dict

Handled in the SDK (https://github.com/databricks/databricks-sdk-py/releases/tag/v0.38.0)
databrickslabs · Nov 19, 2024 · 9244a65 · 9244a65
1 parent cac0b6e
commit 9244a65
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/databricks/labs/lsql/dashboards.py b/src/databricks/labs/lsql/dashboards.py
@@ -1133,9 +1133,9 @@ def create_dashboard(
             warehouse_id=warehouse_id,
         )
         if dashboard_id is not None:
-            sdk_dashboard = self._ws.lakeview.update(dashboard_id, dashboard=dashboard_to_create.as_dict())  # type: ignore
+            sdk_dashboard = self._ws.lakeview.update(dashboard_id, dashboard=dashboard_to_create)
         else:
-            sdk_dashboard = self._ws.lakeview.create(dashboard=dashboard_to_create.as_dict())  # type: ignore
+            sdk_dashboard = self._ws.lakeview.create(dashboard=dashboard_to_create)
         if publish:
             assert sdk_dashboard.dashboard_id is not None
             self._ws.lakeview.publish(sdk_dashboard.dashboard_id, warehouse_id=warehouse_id)

diff --git a/tests/integration/test_dashboards.py b/tests/integration/test_dashboards.py
@@ -58,7 +58,7 @@ def create(*, display_name: str = "") -> SDKDashboard:
             display_name = f"created_by_lsql_{make_random()}"
         else:
             display_name = f"{display_name} ({make_random()})"
-        dashboard = ws.lakeview.create(dashboard=SDKDashboard(display_name=display_name).as_dict())
+        dashboard = ws.lakeview.create(dashboard=SDKDashboard(display_name=display_name))
         if is_in_debug():
             dashboard_url = f"{ws.config.host}/sql/dashboardsv3/{dashboard.dashboard_id}"
             webbrowser.open(dashboard_url)