Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed yaml optional import error #38

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fixed yaml optional import error #38

merged 1 commit into from
Feb 1, 2024

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Feb 1, 2024

This PR really makes the yaml import optional.

This PR really makes the `yaml` import optional.
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (680a9bd) 77.11% compared to head (757f70c) 77.13%.

Files Patch % Lines
src/databricks/labs/blueprint/installation.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   77.11%   77.13%   +0.01%     
==========================================
  Files          13       13              
  Lines        1254     1255       +1     
  Branches      225      225              
==========================================
+ Hits          967      968       +1     
  Misses        197      197              
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx merged commit 96c34f9 into main Feb 1, 2024
9 checks passed
@nfx nfx deleted the fix/yaml-import branch February 1, 2024 12:46
nfx added a commit that referenced this pull request Feb 1, 2024
* Added more integration tests for `Installation` ([#39](#39)).
* Fixed `yaml` optional import error ([#38](#38)).
@nfx nfx mentioned this pull request Feb 1, 2024
nfx added a commit that referenced this pull request Feb 1, 2024
* Added more integration tests for `Installation`
([#39](#39)).
* Fixed `yaml` optional import error
([#38](#38)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant