-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages for Redshift load errors #53
Conversation
Current coverage is
|
Hmm, I guess this should also include the destination table name in the error message. |
This is awesome, thanks for adding this, much sanity saved here :) I don't recall exactly what the default permissions situation is for the load errors table. If it's the case that new users need an explicit grant to be run before they can query it, we might want to add a note to the docs that tells users they need to do this to enable better error messages. It's possible that Redshift actually does something magic where you can only read rows added by loads from your own user account, in which case it should just work I guess. |
Nice! I believe anyone can read from |
LGTM |
This patch allows users to specify a `maxlength` column metadata entry for string columns in order to control the width of `VARCHAR` columns in generated Redshift table schemas. This is necessary in order to support string columns that are wider than 256 characters. In addition, this configuration can be used as an optimization to achieve space-savings in Redshift. For more background on the motivation of this feature, see #29. See also: #53 to improve error reporting when LOAD fails. Author: Josh Rosen <[email protected]> Closes #54 from JoshRosen/max-length.
This patch improves our error reporting for Redshift LOAD errors. When a load error occurs, we will now try to automatically fetch more detailed error information from Redshift's STL_LOAD_ERRORS table.
As an example of the improved error messages:
Old:
New: