Standardize code style using Black #1301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
add-black-fix
branch
3 times, most recently
from
f9920c4 to
89a7a5c
Compare
HyukjinKwon
changed the title
3 tasks
HyukjinKwon
force-pushed
the
add-black-fix
branch
from
89a7a5c to
38a701f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
==========================================
- Coverage 95.06% 95.04% -0.03%
==========================================
Files 34 34
Lines 7233 7238 +5
==========================================
+ Hits 6876 6879 +3
- Misses 357 359 +2
Continue to review full report at Codecov.
|
deepyaman
approved these changes
Feb 21, 2020
Co-authored-by: Deepyaman Datta <[email protected]>
HyukjinKwon
force-pushed
the
add-black-fix
branch
from
c31f5ef to
27cd200
Compare
|
I manually pushed to keep the co-author - 30b3334 Let's see if it's really useful ... |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add Black into Koalas.
dev/linter-pythondetects if codes are formatted or not by Blackdev/reformatscript that reformats the codes by using black.E231andE203at pycodestyle. See also Provide lists of lint / pycodestyle rules that Black makes obsolete psf/black#429 and Black incorrectly preserves trailing comma on one-line collection literals and function declarations psf/black#1202. Black automatically formats and violates several rules.Resolve #755