Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single quotes in gets in templates #889

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

benc-db
Copy link
Collaborator

@benc-db benc-db commented Dec 20, 2024

Description

Discovered when I was trying to add a new config entry that:

config.get('foo')

and

config.get("foo")

behave differently in Jinja templates. This is crazy. I believe this only applies to the config dictionary, but to be safe, every place we use get in the templates, I want to use single quotes.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@benc-db benc-db merged commit b0ff51b into main Dec 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant