Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings and test issues #843

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Cleanup warnings and test issues #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46db57d
get rid of pydantic warnings
benc-db Nov 13, 2024
250424f
skip iceberg for now
benc-db Nov 13, 2024
3a896ab
changelog
benc-db Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
- Upgrade databricks-sql-connector dependency to 3.5.0 ([833](https://github.com/databricks/dbt-databricks/pull/833))
- Prepare for python typing deprecations ([837](https://github.com/databricks/dbt-databricks/pull/837))
- Fix behavior flag use in init of DatabricksAdapter (thanks @VersusFacit!) ([836](https://github.com/databricks/dbt-databricks/pull/836))
- Restrict pydantic to V1 per dbt Labs' request ([843](https://github.com/databricks/dbt-databricks/pull/843))

## dbt-databricks 1.8.7 (October 10, 2024)

Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ dbt-adapters>=1.7.0, <2.0
databricks-sdk==0.17.0
keyring>=23.13.0
protobuf<5.0.0
pydantic>=1.10.0, <2
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def _get_plugin_version() -> str:
"keyring>=23.13.0",
"pandas<2.2.0",
"protobuf<5.0.0",
"pydantic>=1.10.0, <2",
],
zip_safe=False,
classifiers=[
Expand Down
6 changes: 4 additions & 2 deletions tests/functional/adapter/iceberg/test_iceberg_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
from dbt.artifacts.schemas.results import RunStatus


@pytest.mark.skip_profile("databricks_cluster")
# @pytest.mark.skip_profile("databricks_cluster")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you comment out instead of deleting it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only temporary until next week, when the fix will get released to prod.

@pytest.mark.skip("Skip for now as it is broken in prod")
class TestIcebergTables:
@pytest.fixture(scope="class")
def models(self):
Expand All @@ -20,7 +21,8 @@ def test_iceberg_refs(self, project):
assert len(run_results) == 3


@pytest.mark.skip_profile("databricks_cluster")
# @pytest.mark.skip_profile("databricks_cluster")
@pytest.mark.skip("Skip for now as it is broken in prod")
class TestIcebergSwap:
@pytest.fixture(scope="class")
def models(self):
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/python/test_python_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def test_parsed_model__run_name(self):
assert model.run_name.startswith("hive_metastore-default-test-")

def test_parsed_model__invalid_config(self):
parsed_model = {"alias": "test", "config": []}
parsed_model = {"alias": "test", "config": 1}
with pytest.raises(ValidationError):
ParsedPythonModel(**parsed_model)

Expand Down
Loading