-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #582: User Configurable OAuth Scopes in profiles.yml #641
FIX #582: User Configurable OAuth Scopes in profiles.yml #641
Conversation
51af728
to
aa00f2c
Compare
…plication. Signed-off-by: Steven Ayers <[email protected]>
aa00f2c
to
fe3f45a
Compare
Signed-off-by: Steven Ayers <[email protected]>
df5d339
to
7cd1a87
Compare
So, there's an issue that I'm trying to work through with the Databricks SDK folks where the scopes get overridden for Azure which is why I hadn't done this already, but if you can verify this fixes things for your AWS use-case, we can consider merging before that fix is ready. |
If the OAuth application has only been configured with SQL access scopes or a custom redirect URL, you may need to update your profile accordingly: | ||
|
||
``` YAML | ||
jaffle_shop: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate you updating the readme :)
Ah I see. Well, for AWS it seems to be working well with just this fix. I'm pointing our requirements.txt to my fork on github for now, but would be great to have it merged in and released. 🙂 |
Hi @benc-db, will this be released in |
1.7.14, we just forgot to update the changelog. |
Would be good to add this to the docs! |
Resolves #582
Description
As @benc-db mentioned here, it could be worth adding user configurable options for oauth apps to profiles.
@benc-db adds
oauth_redirect_url
to profiles.yml in #638 but we also need to makeoauth_scopes
user-configurable.Usage
Given the app connection:
![Screenshot 2024-04-13 at 08 07 56](https://private-user-images.githubusercontent.com/16361214/322184925-59136104-4d6f-4c6a-90aa-9c60bebe5f45.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzc5NzEsIm5iZiI6MTczOTE3NzY3MSwicGF0aCI6Ii8xNjM2MTIxNC8zMjIxODQ5MjUtNTkxMzYxMDQtNGQ2Zi00YzZhLTkwYWEtOWM2MGJlYmU1ZjQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA4NTQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2NWE2MWNhNzg3M2NlZWQ5ODc5ZTZkNzlhNmU0ZjUwNjdiODEzNTEwNGYyYWM3MjcxMGFjN2UxN2QzYWYwOTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BBitWwkCCdxk229hCvUYcHduyF8VvfmVU_RwvKi-Grg)
Profile configuration would be:
Checklist
CHANGELOG.md
and added information about my change to the "dbt-databricks next" section.