Fixes BUG #582 #632
Closed
Fixes BUG #582 #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change OAUTH callback, priveleges
johnsequeira-paradigm
requested review from
andrefurlan-db,
benc-db and
rcypher-databricks
as code owners
added oauth fix mention
|
@andrefurlan-db please validate that this change is safe. If not, I will prioritize exposing these as configurable instead. |
|
Hi @johnsequeira-paradigm. I believe this will break some existing deployments, so I have put out a new PR to make this user-configurable. Thanks for your contribution, as it lit a fire under to me to get the configurable change out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change OAUTH callback, priveleges
Resolves #582
Description
The bug report describes the params that are incorrect.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.