Follow enhancement/refactor python submission in dbt-spark #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Sep 23, 2022
ChenyuLInx
suggested changes
Sep 23, 2022
| api_client.close() | ||
| @property | ||
| def python_submission_helpers(self) -> Dict[str, Type[PythonJobHelper]]: | ||
| return {"commands": CommandApiPythonJobHelper} |
There was a problem hiding this comment.
Hey @ueshin sorry for updating things so frequent, but after talking to @lostmygithubaccount we decided to update the submission method to reflect the cluster type that we run python model on instead of the API we use.
Here's the change on the dbt-spark side.
I think for here all we need to do is change commands to all_purpose_cluster
Suggested change
| return {"commands": CommandApiPythonJobHelper} | |
| return {"all_purpose_cluster": CommandApiPythonJobHelper} |
There was a problem hiding this comment.
oh, and maybe check_credentials was changed.
Thanks for letting me know. I'll handle it.
There was a problem hiding this comment.
Made minimum changes. I'll submit a follow-up PR.
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182
Description
Follows enhancement/refactor python submission in dbt-labs/dbt-spark#452 and dbt-labs/dbt-core#5822.