-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python 3.13 & remove various version caps #504
Conversation
] | ||
lz4 = "^4.0.2" | ||
requests = "^2.18.1" | ||
oauthlib = "^3.1.0" | ||
numpy = [ | ||
{ version = "^1.16.6", python = ">=3.8,<3.11" }, | ||
{ version = "^1.23.4", python = ">=3.11" }, | ||
{ version = ">=1.16.6", python = ">=3.8,<3.11" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason 01e998c#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 reverted the change made in d690516 to remove the version caps.
* Remove upper caps on numpy and pyarrow versions Signed-off-by: David Black <[email protected]>
Signed-off-by: David Black <[email protected]>
Signed-off-by: David Black <[email protected]>
Signed-off-by: David Black <[email protected]>
@dbaxa Python3.13 testing can be included. As far as relaxing the numpy version we reverted it as it had compatibility issues with pandas - https://pandas.pydata.org/docs/whatsnew/v2.2.2.html#pandas-2-2-2-is-now-compatible-with-numpy-2-0 |
@jprakash-db can you provide more details about the compatibility issues? In our use case we didn't see any problems with using python 3.13 pandas 2.2.3 & numpy 2.2.3 when using a modified version of As in
doesn't seem like an issue to me because |
As In this code base we only rely on Our contract is with the public API of
...so if that is not the case we should open an issue (or PR) in the Packaging bugs occur (all the time!) but if this pin here is to work around a mis-specified dependency that |
Thanks for raising this : dhirschfeld, this makes sense to me. I am closing this in favour of #510 |
Add support for python 3.13 & remove various version caps