Make auth provider configurable #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjakobs
requested review from
arikfr,
moderakh,
superdupershant,
yunbodeng-db,
kravets-levko,
susodapop and
nithinkdb
as code owners
fjakobs
force-pushed
the
custom-auth-provider
branch
3 times, most recently
from
38b498c to
8a809a5
Compare
kravets-levko
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Hi @fjakobs! This PR looks good and I'm going to merge it. But can you please sign-off your commits to make DCO check pass (see our contributing guide)? You can reword previous commit messages with an interactive rebase (git rebase -i main). Thank you!
fjakobs
force-pushed
the
custom-auth-provider
branch
2 times, most recently
from
167a060 to
0be8cae
Compare
Signed-off-by: Fabian Jakobs <[email protected]>
fjakobs
force-pushed
the
custom-auth-provider
branch
from
0be8cae to
deb7fcd
Compare
|
I did the attribution of the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the SQLTools driver for Databricks I want to leverage the auth provider from the VSCode extension. I need to be able to provide a customer auth provider because my tokens expire and I need a way to update them dynamically.
See databricks/sqltools-databricks-driver#60