Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client/secret auth #186

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fix client/secret auth #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions databricks/sdk/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,14 @@ def inner() -> Dict[str, str]:
def oauth_service_principal(cfg: 'Config') -> Optional[HeaderFactory]:
""" Adds refreshed Databricks machine-to-machine OAuth Bearer token to every request,
if /oidc/.well-known/oauth-authorization-server is available on the given host. """
# TODO: change to use cfg.oidc_endpoints (and add cache there)
# TODO: Azure returns 404 for UC workspace after redirecting to
# https://login.microsoftonline.com/{cfg.azure_tenant_id}/.well-known/oauth-authorization-server
resp = requests.get(f"{cfg.host}/oidc/.well-known/oauth-authorization-server")
if not resp.ok:
oidc = cfg.oidc_endpoints
if oidc is None:
return None
token_source = ClientCredentials(client_id=cfg.client_id,
client_secret=cfg.client_secret,
token_url=resp.json()["token_endpoint"],
token_url=oidc.token_endpoint,
scopes=["all-apis"],
use_header=True)

Expand Down