add reference genome compatibility modal #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying bedhost-ui with
|
| Latest commit: |
a68595a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4be06fa3.bedhost.pages.dev |
| Branch Preview URL: | https://genome-compatibility.bedhost.pages.dev |
|
Looks good however, we should clarify for SF: Sequence Fit: the proportion of shared region lengths in both this BED file and reference genome over the total number of region lengths in the reference genome [precision].
|
donaldcampbelljr
approved these changes
Feb 18, 2025
nleroy917
approved these changes
Feb 18, 2025
ui/src/pages/bed-splash.tsx
Outdated
| data: genomeStats, | ||
| } = useBedGenomeStats({ | ||
| md5: bedId, | ||
| autoRun: true, |
There was a problem hiding this comment.
If we always want to auto run this you can probably just set it in the query hook
ui/src/queries/useBedGenomeStats.ts
Outdated
| const { data } = await api.get<BedGenomeStatsResponse>(`/bed/${md5}/genome-stats`); | ||
| return data; | ||
| }, | ||
| enabled: enabled, |
There was a problem hiding this comment.
I saw you had autoRun... do we want to always run? Could just get rid of it here
There was a problem hiding this comment.
Updated, just set enabled to !!md5
khoroshevskyi
approved these changes
Feb 18, 2025
|
I forgot, let me add before we merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple modal with table to show ranking of reference genome compatibilities for now. Is it worth adding the other metrics besides tier_ranking from the /bed/bed_id/genome-stats endpoint?