Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migration stateless test 05_ddl and 06_show #6802

Merged
merged 10 commits into from
Jul 26, 2022
Merged

ci: migration stateless test 05_ddl and 06_show #6802

merged 10 commits into from
Jul 26, 2022

Conversation

ZeaLoVe
Copy link
Contributor

@ZeaLoVe ZeaLoVe commented Jul 25, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. Migration stateless test 05_ddl and 06_show to logic test
  2. Fix gen_suites.py an end-line empty space problem

Fixes #issue

@vercel
Copy link

vercel bot commented Jul 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 9:52AM (UTC)

@mergify mergify bot added the pr-build this PR changes build/testing/ci steps label Jul 25, 2022
@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Jul 25, 2022

SHOW SETTINGS LIKE 'enable%';
http handler with planner_v2 get an error, I just skip it. cc @youngsofun
<1005: errno:1005,msg:sql parser error: Expected end of statement, found: LIKE>

@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Jul 25, 2022

@drmingdrmer
Copy link
Member

ci failed https://github.com/datafuselabs/databend/runs/7496671712?check_suite_focus=true , because I delete stateless test 05_ddl dir. I see https://github.com/datafuselabs/databend/blob/main/tests/compat/test-compat.sh#L187-L198 meta will run 05_ddl test, It is redundant? cc @drmingdrmer

Hmmm... It's not redundant. It is meant to test if different versions of databend-query and databend-meta work smoothly. E.g., query-0.5 and meta-0.6

Since only ddl operations are related to query-meta operation, only these tests are run.

What's the command if I'd like to run the new 05_ddl tests?

@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Jul 25, 2022

OK, I see, let me get this done.

@drmingdrmer
Copy link
Member

OK, I see, let me get this done.

Ok. If you got trouble with it. Let me do it.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ZeaLoVe ZeaLoVe closed this Jul 26, 2022
@ZeaLoVe ZeaLoVe reopened this Jul 26, 2022
@ZeaLoVe

This comment was marked as resolved.

@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Jul 26, 2022

Seems old logictest in v0.7.57 has some issue with python3.9, I just use some commands to make it run. If test-compact failed again, we should not merge it util all problem solved.

@mergify mergify bot merged commit d06ddcf into databendlabs:main Jul 26, 2022
@ZeaLoVe ZeaLoVe deleted the test-migration-05-06 branch August 16, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants