Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(executor): support abort for pipeline executor stream #5803

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

zhang2014
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fixes(executor): support abort for pipeline executor stream

Changelog

  • Bug Fix

Related Issues

Fixes #4871

@vercel
Copy link

vercel bot commented Jun 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 6, 2022 at 0:54AM (UTC)

@zhang2014 zhang2014 requested review from BohuTANG and TCeason June 6, 2022 11:28
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 6, 2022
@zhang2014
Copy link
Member Author

Maybe we need to add a test, but I don't know how to do it.

@TCeason
Copy link
Collaborator

TCeason commented Jun 6, 2022

Maybe we need to add a test, but I don't know how to do it.

tests/suites/1_stateful/02_query/02_0000_kill_query.py

replace SQL SELECT SLEEP(2.9) to which you want to test.

@BohuTANG
Copy link
Member

BohuTANG commented Jun 6, 2022

How about the insert query?

@zhang2014
Copy link
Member Author

zhang2014 commented Jun 6, 2022

How about the insert query?

insert query is different select query. In insert query, we always return stream when all data is wrote. abort insert query require some refactoring, which is in my todo list.

issue: #4646

@TCeason
Copy link
Collaborator

TCeason commented Jun 6, 2022

LGTM and I can modify the test for this pr.

@BohuTANG BohuTANG merged commit 396b5f6 into databendlabs:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: MySQL handler Kill Query
4 participants