fix: purge may not work on tables after a flash back operation #16812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantengsky
approved these changes
Nov 12, 2024
zhyass
approved these changes
Nov 12, 2024
PR summary updated, pls let me know if there are any other concerns. |
dantengsky
pushed a commit
to dantengsky/fuse-query
that referenced
this pull request
Nov 12, 2024
…endlabs#16812) * fix: purge may not work on tables after a flash back operation * fix * fix test * fix test
11 tasks
dantengsky
added a commit
that referenced
this pull request
Nov 12, 2024
…tion (#16812) (#16816) fix: purge may not work on tables after a flash back operation (#16812) * fix: purge may not work on tables after a flash back operation * fix * fix test * fix test Co-authored-by: Sky Fan <[email protected]>
dantengsky
added a commit
that referenced
this pull request
Nov 25, 2024
…tion (#16812) (#16816) fix: purge may not work on tables after a flash back operation (#16812) * fix: purge may not work on tables after a flash back operation * fix * fix test * fix test Co-authored-by: Sky Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
On tables that have undergone a FLASHBACK operation, this assumption is broken:
In this PR, the garbage collection root is determined by starting from the current snapshot and traversing backward to the target time point using the
prevrelation between snapshots. This approach enhances safety (allowing tables modified by theALTER ... FLASHBACKoperation to be handled correctly) but may require traversing a (much) longer history of the table being purged.Tests
Type of change
This change is