feat: filter null value before join #16722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
xudong963
force-pushed
the
filter_nulls_before_join
branch
4 times, most recently
from
7d92cf5
to
e2a2f47
Compare
|
#16739 fix ci err |
xudong963
force-pushed
the
filter_nulls_before_join
branch
from
8d9a98f
to
2590e8f
Compare
Dousir9
reviewed
Nov 1, 2024
src/query/sql/src/planner/optimizer/rule/rewrite/rule_filter_nulls.rs
Outdated
Show resolved
Hide resolved
Dousir9
reviewed
Nov 1, 2024
xudong963
force-pushed
the
filter_nulls_before_join
branch
2 times, most recently
from
e988d34
to
c50e8c0
Compare
xudong963
force-pushed
the
filter_nulls_before_join
branch
4 times, most recently
from
510630c
to
edae83e
Compare
xudong963
force-pushed
the
filter_nulls_before_join
branch
from
edae83e
to
7c87acf
Compare
Dousir9
approved these changes
Nov 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dousir9
pushed a commit
to dantengsky/fuse-query
that referenced
this pull request
Nov 27, 2024
* feat: filter null value before join * fix lint * add annotations and process possible crash * dedup filters and fix tests (also need to fix native explain test) * fix test * support semi join * fix test for semi join * adjust threshold and enable only distribution
dantengsky
added a commit
that referenced
this pull request
Nov 27, 2024
) * feat: implement `is_not_null` selectivity based on null count in stats (#16730) * feat: implement is_not_null selectivity based on null count in stats * fix test * chore(planner): improve cardinality estimation (#16938) * chore(planner): improve cardinality estimation * chore(planner): improve histogram cardinality estimation * chore(planner): improve join cardinality * chore(test): update sqllogictest * chore(test): update sqllogictest * chore(code): refine code * chore(test): update sqllogictest * chore(test): test ci tpch * chore(code): fix typos * chore(test): remove accurate_his test * chore(test): fix sqllogictest * chore(query): fix sub overflow * chore(planner): refine scan histogram * chore(test): update sqllogictest * chore(test): update sqllogictest * ci: fix flaky test (#16945) * ci: fix flaky test #16935 * ci: update error format of Bendsql. * feat: filter null value before join (#16722) * feat: filter null value before join * fix lint * add annotations and process possible crash * dedup filters and fix tests (also need to fix native explain test) * fix test * support semi join * fix test for semi join * adjust threshold and enable only distribution * chore(planner): resolve conflicts * fix(query): support subquery in pivot (#16631) * fix(query): support subquery in pivot * add pivot and unpivot sqllogictests, fix unit-test * code format * chore(code): resolve conflicts * chore(test): update sqllogictest * chore(test): update sqllogictest * Revert "ci: fix flaky test (#16945)" This reverts commit efcbac3. * chore: add extra bracket for `and` and `or` to make explain clear (#16494) * fix: add extra bracket for and or * add task test * chore(test): update sqllogictest * Revert "Revert "ci: fix flaky test (#16945)"" This reverts commit 49ea151. * fix(query): forbid explain explain statement (#16654) fix(query): forbiden explain explain statement * fix(ci): flaky test (#16933) * flaky test * fix * fix test * chore(code): resolve conflicts * chore(test): update test --------- Co-authored-by: xudong.w <[email protected]> Co-authored-by: Jk Xu <[email protected]> Co-authored-by: Yang Xiufeng <[email protected]> Co-authored-by: Liu Zhenlong <[email protected]> Co-authored-by: Dousir9 <[email protected]> Co-authored-by: TCeason <[email protected]> Co-authored-by: zhya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Many columns in tpcds contain a lot of NULL values.
When they're used as join keys for inner join, we can generate
not nullfilters and push down them to scan, then reduce I/O cost and network cost.Tests
Type of change
This change is