Improve coverage on edge cases + misc. testing #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 9, 2018 22:45
|
Tests are failing because of a bug that exists in |
nbgl
commented
Jul 24, 2018
| @@ -1,15 +1,14 @@ | |||
|
|
|||
There was a problem hiding this comment.
This whole file was reverted to the pre-multiparty version. This is so the PR I make later is strictly additive and we can check that it doesn’t break anything.
The only change I made from the pre-multiparty version is fixing the interaction with Clkhash so it uses the newer API.
nbgl
commented
Jul 24, 2018
| @@ -0,0 +1,253 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
This file is mostly the same as test_similarity.py, but it uses the new API instead of the old API.
nbgl
commented
Jul 24, 2018
| @@ -3,10 +3,13 @@ | |||
| import random | |||
| import unittest | |||
|
|
|||
| import bitarray | |||
| import pytest | |||
There was a problem hiding this comment.
In addition to adding tests, I also modified this file to use Pytest instead of Unittest.
added 2 commits
July 24, 2018 10:20
…w-test-edge-cases. This should make the tests pass.
hardbyte
approved these changes
Jul 24, 2018
nbgl
added a commit
that referenced
this pull request
Aug 1, 2018
* Blocking functions * Minor docstring * Types for Mypy * Hamming similarity * Refactor tests * Minor refactor * Require NumPy * Multiparty greedy solver * Candidate generation. Still missing some features * Some optimisations * More optimisation * Still optimising * Ready for PR * Hamish PR comments * Fix Python 3.5 bug * Serialization * Serialisation of candidate pairs! * Update typechecking. * Fix typing * Fix tests on big numbers * Oops. Minor. * Minor comment * Brian PR comments * Bug fix + more Pythonic type checking * Only test on >=Python3.6 * Travis does not yet have Python 3.7... * GPU 1 does not yet have Python 3.7 * Hamish PR comments * Revert release to Python 3.6 * I forgot to commit this before merging… (#119) * Candidate generation refactor (#122) * Candidate generation * Minor docstring * Typo in docstring * Hamish PR Comments * New API for Dice Coefficient (#121) * New API for Dice Coefficient * Docstrings * Minor PEP8 * Typing * Make tests pass… * Brian PR comments * Mypy typing + make API nice and unified (#123) * Type hints * Bring Hamming similarity in line with rest of API * Make solver tests pass * Ok, solving tests should finally work now... * Brian PR comments * Make typechecking.Record importable * Add dependency on mypy extensions * Blocking style (#125) * Blocking style * Minor commenting * Improve coverage on edge cases + misc. testing (#127) * Type hints * Bring Hamming similarity in line with rest of API * Make solver tests pass * Ok, solving tests should finally work now... * Edge cases and tests * Restore old similarity tests * Minor: I don't know how that typo got there * Make Dice similarity tests pass with new Clkhash * Minor: unused imports * Style and docstrings (#130) * Style and comments * More style and comments * Mypy * Minor: Fix link * Brian PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_similarity.pyto previous, so we still test the old Dice coefficient APItest_similarity_hamming.pyandtest_similarity_dice.pyrespectively