Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci cluster #476

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Update ci cluster #476

merged 1 commit into from
Feb 4, 2020

Conversation

hardbyte
Copy link
Collaborator

@hardbyte hardbyte commented Feb 3, 2020

Refactors most of the Kubernetes related CI testing to use azure's service connections and to migrate to our newer cluster.

Copy link
Contributor

@joyceyuu joyceyuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These is the most complicated azure pipeline yaml file I ever seen 👍 I have checked the build pipeline on Azure. They all look good to me. So I would like to approve. Just see a warning on Azure: #[warning]All the containers are not in a ready state. If it is not a problem, then I am happy for this branch to be merged.

command: 'wait'
arguments: '--namespace $(NAMESPACE) -ldeployment=$(DEPLOYMENT) --timeout=30s --for=condition=Ready pods'

- task: Kubernetes@1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering what is the difference between Kubernetes@0 and Kubternetes@1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions of the task - if there is a Kubernetes@0 I should update it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they are fine. If you're interested in the docs have a look here

@hardbyte
Copy link
Collaborator Author

hardbyte commented Feb 4, 2020

These is the most complicated azure pipeline yaml file I ever seen

:-( Perhaps it needs to be split further into templates. I suggest merging so we can rebase the other work and keep developing though.

The deployment warning is fine - I've seen that when the redis self test pod doesn't work.

Copy link
Collaborator

@wilko77 wilko77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff is way over my head...

For some jobs you changed the image from ubuntu-16.04 to ubuntu-latest and for others you didn't. Is there a reason for this?

Now the connection to the Kubernetes cluster uses a configurable Service Connection
@hardbyte hardbyte merged commit d354516 into develop Feb 4, 2020
@hardbyte hardbyte deleted the update-ci-cluster branch February 4, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants