Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unknown remote object size #431

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Allow unknown remote object size #431

merged 4 commits into from
Mar 7, 2024

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Mar 6, 2024

This PR handles the edge case when remote data source report object size as unknown (-1)

  • The size will not be part of the condition to determine if this file already exists in the database
  • Once prepared, the size of the file will be updated to the correct size

Caveats

  • Since the size is unknown, it's possible that the files within a job may overflow the sector size
  • A warning message is logged so the user is aware

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 74.08%. Comparing base (03cd9d9) to head (5ac733d).

Files Patch % Lines
pack/pack.go 70.00% 4 Missing and 2 partials ⚠️
pack/assembler.go 57.14% 2 Missing and 1 partial ⚠️
pack/push/pushfile.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   74.05%   74.08%   +0.03%     
==========================================
  Files         150      150              
  Lines        9954     9980      +26     
==========================================
+ Hits         7371     7394      +23     
- Misses       1824     1826       +2     
- Partials      759      760       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu changed the title Lint fix Allow remote item size = -1 Mar 7, 2024
@xinaxu xinaxu changed the title Allow remote item size = -1 Allow unknown remote object size Mar 7, 2024
@xinaxu xinaxu merged commit 9c76b91 into main Mar 7, 2024
9 of 10 checks passed
@xinaxu xinaxu deleted the xinaxu/lint-fix branch March 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants