-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: find endpoints asynchronously, cache errors #419
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 74.02% 74.08% +0.06%
==========================================
Files 149 150 +1
Lines 9823 9880 +57
==========================================
+ Hits 7271 7320 +49
- Misses 1802 1807 +5
- Partials 750 753 +3
☔ View full report in Codecov by Sentry. |
a00fec2
to
889cd19
Compare
2585c02
to
8664bbf
Compare
@gammazero PTAL I've switched to an options pattern for this but also slightly changed the parallelism such that it only forks a goroutine if there's something to look up, so the common call here will just bounce right through and collect values from the cache, no goroutine, no channels. Can you sanity check the logic for me please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question.
8a7bad5
to
dd7d1a7
Compare
Goals:
Critique of my design decisions welcome of course, there's a bunch of ways this could be done, I made some choices.