Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max replica constraint #408

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Add max replica constraint #408

merged 1 commit into from
Oct 31, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Oct 30, 2023

fixes #315
fixes #209

Adds a flag to limit number of replicas per PieceCID.
Long term goal is to offer a more granular way to define number of replicas. For now, we'll use a global flag.

@xinaxu xinaxu requested a review from masih October 30, 2023 22:11
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eedbb4d) 73.92% compared to head (9946703) 73.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   73.92%   73.93%   +0.01%     
==========================================
  Files         149      149              
  Lines        9813     9829      +16     
==========================================
+ Hits         7254     7267      +13     
- Misses       1809     1811       +2     
- Partials      750      751       +1     
Files Coverage Δ
cmd/run/dealpusher.go 47.05% <100.00%> (ø)
service/dealpusher/dealpusher.go 74.24% <100.00%> (+1.01%) ⬆️
util/testutil/testutils.go 88.39% <100.00%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit 5ac8d75 into main Oct 31, 2023
@xinaxu xinaxu deleted the xinaxu/max-replica branch October 31, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants