Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting identity during admin init #402

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Oct 24, 2023

Due to how Motion docker compose is structured, the best way to set the identity to motion is through the admin init CLI command.

This is part of filecoin-project/motion#174

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8c2efb8) 73.94% compared to head (696a737) 71.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   73.94%   71.21%   -2.74%     
==========================================
  Files         148      148              
  Lines        9658     9669      +11     
==========================================
- Hits         7142     6886     -256     
- Misses       1774     2073     +299     
+ Partials      742      710      -32     
Files Coverage Δ
cmd/admin/init.go 50.00% <50.00%> (-7.15%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit 673b052 into main Oct 24, 2023
@xinaxu xinaxu deleted the xinaxu/init-with-identity branch October 24, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant