Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text corrections #370

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

criadoperez
Copy link
Contributor

Replaces PR #359
Text corrections on multiple files.
make generate and make lint passed.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d545543) 74.30% compared to head (386c700) 74.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   74.30%   74.36%   +0.06%     
==========================================
  Files         143      143              
  Lines        9433     9433              
==========================================
+ Hits         7009     7015       +6     
+ Misses       1709     1705       -4     
+ Partials      715      713       -2     
Files Coverage Δ
docs/swagger/docs.go 100.00% <ø> (ø)
handler/deal/schedule/create.go 89.43% <ø> (ø)
handler/deal/schedule/update.go 91.36% <ø> (ø)
handler/wallet/listattached.go 70.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu
Copy link
Contributor

xinaxu commented Oct 7, 2023

hmm. Not sure why the generated file is different for you.
If you checkout to main branch and run make generate will it show any modified files after the generation?

@xinaxu
Copy link
Contributor

xinaxu commented Oct 8, 2023

@criadoperez
Copy link
Contributor Author

hmm. Not sure why the generated file is different for you. If you checkout to main branch and run make generate will it show any modified files after the generation?

Running make generate on main produced change on 4 files. As main updated recently I also later synced my fork and run make generate again producing the same results. Modifying the same 4 files.

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   docs/en/SUMMARY.md
        modified:   docs/en/cli-reference/storage/create/README.md
        modified:   docs/en/cli-reference/storage/update/README.md
        modified:   handler/storage/types_gen.go

no changes added to commit (use "git add" and/or "git commit -a")

@criadoperez
Copy link
Contributor Author

Try run this workflow in your forked repo. https://github.com/data-preservation-programs/singularity/actions/workflows/auto-generate.yml

Sure thing. Currently running...

@xinaxu
Copy link
Contributor

xinaxu commented Oct 9, 2023

From the file diff, it seems like this may be able to fix the discrepancy here. Can you try merge the latest main and see if it passes CI
#376

@criadoperez
Copy link
Contributor Author

It seems that that made the trick. Finally all checks passed :-)

@xinaxu xinaxu merged commit f9f9d75 into data-preservation-programs:main Oct 10, 2023
@criadoperez criadoperez deleted the fix/20231006 branch October 16, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants