Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize context cancellation with pause command #357

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Oct 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (62ea8bb) 74.09% compared to head (4159129) 74.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   74.09%   74.22%   +0.12%     
==========================================
  Files         142      143       +1     
  Lines        9366     9405      +39     
==========================================
+ Hits         6940     6981      +41     
+ Misses       1711     1709       -2     
  Partials      715      715              
Files Coverage Δ
service/datasetworker/datasetworker.go 86.40% <100.00%> (+7.16%) ⬆️
service/datasetworker/statemonitor.go 77.77% <77.77%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit 454eaa9 into main Oct 1, 2023
@xinaxu xinaxu deleted the xinaxu/cancel-ctx branch October 1, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant