Use echo writer for retrieve #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Sep 23, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 74.32% 74.26% -0.07%
==========================================
Files 143 143
Lines 9433 9433
==========================================
- Hits 7011 7005 -6
- Misses 1708 1712 +4
- Partials 714 716 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix filecoin-project/motion#135
Implementation
I have no idea why not using the underlying HTTP writer fixes the above issue but it most definitely does. Why one would leave a Writer struct member public when using it creates a subtle bug is a mystery to me. I'll take it up with the Echo people.
My hypothesis is the the underlying writer implements ReadFrom and somehow this messes things up. I dunno, or maybe Echo just wants you to work through the response directly.